fix(#234): cache get_next_feed result in GranarySmartFeeder - #247
Open
dennismdejong wants to merge 1 commit into
Open
fix(#234): cache get_next_feed result in GranarySmartFeeder#247dennismdejong wants to merge 1 commit into
dennismdejong wants to merge 1 commit into
Conversation
…tetime computations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234
Problem:
sensor.granary_smart_feeder_right_next_feed_quantity_volumetook 2.284 seconds to update becauseget_next_feedrecomputed timezone-aware datetime math for every feeding plan entry on every call.Fix: Cache the
get_next_feedresult for the duration of each refresh cycle. The cache is invalidated at the start ofrefresh()and the property returns the cached dict on subsequent calls within the same cycle.